Issue 2870027: Fix a memory leak in ExtensionExtentUnittest by fixing a bad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2870027: Fix a memory leak in ExtensionExtentUnittest by fixing a bad (Closed)

Created:
10 years, 6 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews, Alexander Potapenko, Erik does not do reviews, Timur Iskhodzhanov, Aaron Boodman, stuartmorgan, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Fix a memory leak in ExtensionExtentUnittest by fixing a bad API design choice. BUG=47539, 47545 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50912

Patch Set 1 #

Patch Set 2 : remove unneeded header from url_pattern.h #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -36 lines)			Patch
M	chrome/common/extensions/extension_extent_unittest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/url_pattern.h	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/url_pattern.cc	View	1	3 chunks	+9 lines, -10 lines	0 comments	Download
M	tools/heapcheck/suppressions.txt	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages