Fix a memory leak in ExtensionExtentUnittest by fixing a bad

chrome/common/extensions/url_pattern.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/url_pattern.h"
 
-#include "base/scoped_ptr.h"
 #include "base/string_piece.h"
 #include "base/string_util.h"
 #include "chrome/common/url_constants.h"
 
 // TODO(aa): Consider adding chrome-extension? What about more obscure ones
 // like data: and javascript: ?
 static const char* kValidSchemes[] = {
   chrome::kHttpScheme,
   chrome::kHttpsScheme,
   chrome::kFileScheme,
   chrome::kFtpScheme,
   chrome::kChromeUIScheme,
 };
 
 static const char kPathSeparator[] = "/";
 
 // static
-URLPattern* URLPattern::CreateFromString(const std::string& pattern_string) {
-  scoped_ptr<URLPattern> pattern(new URLPattern);
-  if (pattern->Parse(pattern_string))
-    return pattern.release();
-  else
-    return NULL;
-}
-
-// static
 bool URLPattern::IsValidScheme(const std::string& scheme) {
   for (size_t i = 0; i < arraysize(kValidSchemes); ++i) {
     if (scheme == kValidSchemes[i])
       return true;
   }
 
   return false;
 }
 
+URLPattern::URLPattern()
+    : match_subdomains_(false) {}
+
+URLPattern::URLPattern(const std::string& pattern)
+    : match_subdomains_(false) {
+  if (!Parse(pattern))
+    NOTREACHED() << "URLPattern is invalid: " << pattern;
+}
+
 bool URLPattern::Parse(const std::string& pattern) {
   size_t scheme_end_pos = pattern.find(chrome::kStandardSchemeSeparator);
   if (scheme_end_pos == std::string::npos)
     return false;
 
   scheme_ = pattern.substr(0, scheme_end_pos);
   if (!IsValidScheme(scheme_))
     return false;
 
   size_t host_start_pos = scheme_end_pos +
@@ skipping 114 matching lines @@
   }
 
   if (!host_.empty())
     spec += host_;
 
   if (!path_.empty())
     spec += path_;
 
   return spec;
 }