net/socket/ssl_client_socket_mac.cc - Issue 2867026: Make X509Certificate::CreateFromHandle() copy the OSCertHandle, rather than assume ownership

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_mac.cc

Issue 2867026: Make X509Certificate::CreateFromHandle() copy the OSCertHandle, rather than assume ownership (Closed)

Patch Set: Deleted one comment too many Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_mac.cc

diff --git a/net/socket/ssl_client_socket_mac.cc b/net/socket/ssl_client_socket_mac.cc

index 973a77d825c3a2007a10aaffc21bc24ba2251858..f1d2278832aee55850a85060ca87f13a4ef8540c 100644

--- a/net/socket/ssl_client_socket_mac.cc

+++ b/net/socket/ssl_client_socket_mac.cc

@@ -432,7 +432,6 @@ X509Certificate* GetServerCert(SSLContextRef ssl_context) {

SecCertificateRef server_cert = static_cast<SecCertificateRef>(

const_cast<void*>(CFArrayGetValueAtIndex(certs, 0)));

- CFRetain(server_cert);

return X509Certificate::CreateFromHandle(

server_cert, X509Certificate::SOURCE_FROM_NETWORK, intermediate_ca_certs);

}

« no previous file with comments | « net/base/x509_certificate_win.cc ('k') | net/socket/ssl_client_socket_nss.cc » ('j') | no next file with comments »