net/base/x509_certificate_win.cc - Issue 2867026: Make X509Certificate::CreateFromHandle() copy the OSCertHandle, rather than assume ownership

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_certificate_win.cc

Issue 2867026: Make X509Certificate::CreateFromHandle() copy the OSCertHandle, rather than assume ownership (Closed)

Patch Set: Deleted one comment too many Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/x509_certificate_win.cc

diff --git a/net/base/x509_certificate_win.cc b/net/base/x509_certificate_win.cc

index a02db9b7b4fe06262ef55579b28b0f8dc85aab1c..23f423067a501c403c1bfb4de09cc7c9f8eb2b60 100644

--- a/net/base/x509_certificate_win.cc

+++ b/net/base/x509_certificate_win.cc

@@ -482,8 +482,11 @@ X509Certificate* X509Certificate::CreateFromPickle(const Pickle& pickle,

NULL, reinterpret_cast<const void **>(&cert_handle)))

return NULL;

- return CreateFromHandle(cert_handle, SOURCE_LONE_CERT_IMPORT,

- OSCertHandles());

+ X509Certificate* cert = CreateFromHandle(cert_handle,

+ SOURCE_LONE_CERT_IMPORT,

+ OSCertHandles());

+ FreeOSCertHandle(cert_handle);

+ return cert;

}

void X509Certificate::Persist(Pickle* pickle) {

« no previous file with comments | « net/base/x509_certificate_unittest.cc ('k') | net/socket/ssl_client_socket_mac.cc » ('j') | no next file with comments »