Improve testing with File() keyword, found a few bugs along the way

Improve testing with File() keyword, found a few bugs along the way

TEST=new smoke tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51824

[tony, 2010-07-08 02:19:41]

LGTM!

http://codereview.chromium.org/2865039/diff/1/3
File tests/fake_repos.py (right):

http://codereview.chromium.org/2865039/diff/1/3#newcode411
tests/fake_repos.py:411: #         implementation should probably be replaced to
use urllib instead.
Nit: With svn 1.6+, it's better to use svn because we can use 'svn update' like
other submodules.  But you're right, the fallback should probably just use
urllib.

http://codereview.chromium.org/2865039/diff/1/4
File tests/gclient_smoketest.py (right):

http://codereview.chromium.org/2865039/diff/1/4#newcode104
tests/gclient_smoketest.py:104: #self.checkString(results[i][0][2], path)
Nit: remove?

[M-A Ruel, 2010-07-08 02:37:28]

updated, see difference with previous set.

http://codereview.chromium.org/2865039/diff/1/4
File tests/gclient_smoketest.py (right):

http://codereview.chromium.org/2865039/diff/1/4#newcode104
tests/gclient_smoketest.py:104: #self.checkString(results[i][0][2], path)
On 2010/07/08 02:19:41, tony wrote:
> Nit: remove?

I've fixed the expectations instead. svn update for a file is called from a
different directory that the usual code path but this test was already designed
to handle that case nicely, I was just before lazy.