Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: tests/fake_repos.py

Issue 2865039: Improve testing with File() keyword, found a few bugs along the way (Closed)
Patch Set: Update expectations instead of disabling a check Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient.py ('k') | tests/gclient_smoketest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/fake_repos.py
diff --git a/tests/fake_repos.py b/tests/fake_repos.py
index b1a2502c4525699c9afc08c3a71f7b7c97470592..2ce6ea9195796c69cb0cd617cd818bc174174f2b 100755
--- a/tests/fake_repos.py
+++ b/tests/fake_repos.py
@@ -338,8 +338,8 @@ class FakeRepos(object):
# - var
# - hooks
# - From
- # TODO(maruel):
# - File
+ # TODO(maruel):
# - $matching_files
# - use_relative_paths
fs = file_system(1, """
@@ -360,8 +360,8 @@ deps_os = {
fs = file_system(2, """
deps = {
'src/other': 'svn://%(host)s/svn/trunk/other',
- #'src/third_party/foo': '/trunk/third_party/foo@1',
'src/third_party/foo': From('src/other', 'foo/bar'),
+ 'src/file/foo': File('svn://%(host)s/svn/trunk/third_party/foo/origin'),
}
# I think this is wrong to have the hooks run from the base of the gclient
# checkout. It's maybe a bit too late to change that behavior.
@@ -407,7 +407,8 @@ deps = {
# - hooks
# - From
# TODO(maruel):
- # - File
+ # - File: File is hard to test here because it's SVN-only. It's
+ # implementation should probably be replaced to use urllib instead.
# - $matching_files
# - use_relative_paths
self._commit_git('repo_3', {
« no previous file with comments | « gclient.py ('k') | tests/gclient_smoketest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698