Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2865010: Load net-internals resources from resources.pak. (Closed)

Created:
10 years, 6 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Load net-internals resources from resources.pak. This is the same as r50257 with 2 fixes: 1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will work for things tests. 2) Add back the check in chrome_paths.cc to see if we're in a mac bundle or not. BUG=35793, 42770 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50433

Patch Set 1 #

Patch Set 2 : mini installer #

Patch Set 3 : mini installer 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -93 lines) Patch
M app/resource_bundle.h View 1 chunk +3 lines, -2 lines 0 comments Download
M app/resource_bundle.cc View 3 chunks +19 lines, -9 lines 0 comments Download
M base/data_pack.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/data_pack.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/net_internals_ui.cc View 2 chunks +43 lines, -35 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 3 chunks +2 lines, -35 lines 0 comments Download
M chrome/chrome_dll.gypi View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/common/chrome_paths.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_paths.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 2 chunks +1 line, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tony
10 years, 6 months ago (2010-06-22 06:46:23 UTC) #1
Same as patch set 1 except the addition of changes to FILES.cfg and
chrome.release.

Powered by Google App Engine
This is Rietveld 408576698