Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2886)

Unified Diff: app/resource_bundle.cc

Issue 2865010: Load net-internals resources from resources.pak. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: mini installer 2 Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/resource_bundle.h ('k') | base/data_pack.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/resource_bundle.cc
diff --git a/app/resource_bundle.cc b/app/resource_bundle.cc
index dcf7fa8670531a32a96e3d90fc8efae1fa5412b1..d61e83d3c972d2f640274649d2932905db5a4172 100644
--- a/app/resource_bundle.cc
+++ b/app/resource_bundle.cc
@@ -105,7 +105,17 @@ SkBitmap* ResourceBundle::LoadBitmap(DataHandle data_handle, int resource_id) {
RefCountedStaticMemory* ResourceBundle::LoadDataResourceBytes(
int resource_id) const {
- return LoadResourceBytes(resources_data_, resource_id);
+ RefCountedStaticMemory* bytes =
+ LoadResourceBytes(resources_data_, resource_id);
+
+ // Check all our additional data packs for the resources if it wasn't loaded
+ // from our main source.
+ for (std::vector<LoadedDataPack*>::const_iterator it = data_packs_.begin();
+ !bytes && it != data_packs_.end(); ++it) {
+ bytes = (*it)->GetStaticMemory(resource_id);
+ }
+
+ return bytes;
}
SkBitmap* ResourceBundle::GetBitmapNamed(int resource_id) {
@@ -198,11 +208,8 @@ const gfx::Font& ResourceBundle::GetFont(FontStyle style) {
// LoadedDataPack implementation
ResourceBundle::LoadedDataPack::LoadedDataPack(const FilePath& path)
: path_(path) {
- // On unicies, we preload data packs so background updates don't cause us to
- // load the wrong data.
-#if defined(OS_POSIX) && !defined(OS_MACOSX)
+ // Always preload the data packs so we can maintain constness.
Load();
-#endif
}
void ResourceBundle::LoadedDataPack::Load() {
@@ -212,9 +219,12 @@ void ResourceBundle::LoadedDataPack::Load() {
CHECK(success) << "Failed to load " << path_.value();
}
-bool ResourceBundle::LoadedDataPack::GetStringPiece(int resource_id,
- base::StringPiece* data) {
- if (!data_pack_.get())
- Load();
+bool ResourceBundle::LoadedDataPack::GetStringPiece(
+ int resource_id, base::StringPiece* data) const {
return data_pack_->GetStringPiece(static_cast<uint32>(resource_id), data);
}
+
+RefCountedStaticMemory* ResourceBundle::LoadedDataPack::GetStaticMemory(
+ int resource_id) const {
+ return data_pack_->GetStaticMemory(resource_id);
+}
« no previous file with comments | « app/resource_bundle.h ('k') | base/data_pack.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698