Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2864021: Adding a new signature for WebGraphicsContext3DCommandBufferImpl::initialize(... (Closed)

Created:
10 years, 6 months ago by Vangelis Kokkevis
Modified:
9 years, 6 months ago
CC:
chromium-reviews, jam+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Adding a new signature for WebGraphicsContext3DCommandBufferImpl::initialize() in preparation for an upstream change to WebGraphicsContext3D. The proper implementatation of the new initializer will be added once the upstream changes have landed. Also adding getPlatformTextureId() and prepareTexture() which will soon be defined in WebGraphicsContext3D. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51051

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M chrome/renderer/webgraphicscontext3d_command_buffer_impl.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc View 1 2 3 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vangelis Kokkevis
Change is ready for review. Thanks!
10 years, 6 months ago (2010-06-24 22:36:07 UTC) #1
Ken Russell (switch to Gerrit)
10 years, 6 months ago (2010-06-24 23:55:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698