Issue 2863031: Change MenuItems to use divs and add disabled property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2863031: Change MenuItems to use divs and add disabled property (Closed)

Created:
10 years, 5 months ago by feldstein

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Visibility:
Public.

Description

Change MenuItems to use divs and add disabled property Stops using buttons for menu items so that it doesn't conflict with the button.css file. Added a BOOL_ATTR disabled property so the attribute is set on the element. It was originally not being set and not being styled as disabled. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51201

Patch Set 1 #

Patch Set 2 : Should extend div not button. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	chrome/browser/resources/shared/js/cr/ui/menu_item.js	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages