Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2239)

Unified Diff: chrome/browser/resources/shared/js/cr/ui/menu_item.js

Issue 2863031: Change MenuItems to use divs and add disabled property (Closed)
Patch Set: Should extend div not button. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/shared/js/cr/ui/menu_item.js
diff --git a/chrome/browser/resources/shared/js/cr/ui/menu_item.js b/chrome/browser/resources/shared/js/cr/ui/menu_item.js
index 5c66f17254c044798e133ae5e062d7ab57c2a0dc..d570f7880977dbfc725d6c17c2cab4965e989ddc 100644
--- a/chrome/browser/resources/shared/js/cr/ui/menu_item.js
+++ b/chrome/browser/resources/shared/js/cr/ui/menu_item.js
@@ -9,9 +9,9 @@ cr.define('cr.ui', function() {
* Creates a new menu item element.
* @param {Object=} opt_propertyBag Optional properties.
* @constructor
- * @extends {HTMLButtonElement}
+ * @extends {HTMLDivElement}
*/
- var MenuItem = cr.ui.define('button');
+ var MenuItem = cr.ui.define('div');
/**
* Creates a new menu separator element.
@@ -129,6 +129,12 @@ cr.define('cr.ui', function() {
};
/**
+ * Whether the menu item is disabled or not.
+ * @type {boolean}
+ */
+ cr.defineProperty(MenuItem, 'disabled', cr.PropertyKind.BOOL_ATTR);
+
+ /**
* Whether the menu item is hidden or not.
* @type {boolean}
*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698