Issue 2863013: [Mac] UI changes for the Browser Actions toolbar container....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2863013: [Mac] UI changes for the Browser Actions toolbar container.... (Closed)

Created:
10 years, 6 months ago by Bons

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, John Grabowski, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Aaron Boodman

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] UI changes for the Browser Actions toolbar container. o Grippy is hidden for now pending new UI. You can still resize just fine. o The right divider is removed since the wrench menu is now always being shown. TEST=none BUG=45764 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50375

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -100 lines)			Patch
M	chrome/app/nibs/Toolbar.xib	View	1	9 chunks	+10 lines, -12 lines	0 comments	Download
M	chrome/browser/cocoa/extensions/browser_actions_container_view.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/extensions/browser_actions_container_view.mm	View		4 chunks	+1 line, -56 lines	0 comments	Download
M	chrome/browser/cocoa/extensions/browser_actions_controller.mm	View		4 chunks	+7 lines, -12 lines	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller.mm	View		4 chunks	+6 lines, -16 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

10 years, 6 months ago (2010-06-21 17:51:26 UTC) #1

lgtm (resave nib)

http://codereview.chromium.org/2863013/diff/1/6
File chrome/browser/cocoa/toolbar_controller.mm (right):

http://codereview.chromium.org/2863013/diff/1/6#newcode600
chrome/browser/cocoa/toolbar_controller.mm:600: if (leftDistance != 0.0)
Floating-point imprecision is a little scary when it comes to doing exact
comparisons, although I’d be surprised if it caused problems here. The problem
already existed here before.

http://codereview.chromium.org/2863013/diff/1/6#newcode601
chrome/browser/cocoa/toolbar_controller.mm:601: [self
adjustLocationSizeBy:leftDistance animate:animate];
I also guess it won’t cause any problems if leftDistance is “nonzero but zero.”

Expand Messages | Collapse Messages