Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2861043: ARM: Use VFP for non-Smi bitops results. This is basically Rodolph... (Closed)

Created:
10 years, 5 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Use VFP for non-Smi bitops results. This is basically Rodolph Perfettas change from http://codereview.chromium.org/2829032 with a tiny tweak to the unsigned shift right case. Committed: http://code.google.com/p/v8/source/detail?r=5012

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -11 lines) Patch
M src/arm/codegen-arm.cc View 3 chunks +38 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
10 years, 5 months ago (2010-07-02 11:19:23 UTC) #1
William Hesse
Are the negative offsets used anywhere? Maybe a unit test should be written. LGTM.
10 years, 5 months ago (2010-07-02 13:07:40 UTC) #2
Rodolph Perfetta
We intended to use negative offset, but didn't need them in the end.
10 years, 5 months ago (2010-07-02 13:13:48 UTC) #3
Erik Corry
10 years, 5 months ago (2010-07-02 20:05:04 UTC) #4
Committed without the negative offsets part.

Powered by Google App Engine
This is Rietveld 408576698