Issue 2861043: ARM: Use VFP for non-Smi bitops results. This is basically Rodolph...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2861043: ARM: Use VFP for non-Smi bitops results. This is basically Rodolph... (Closed)

Created:
10 years, 5 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
William Hesse, Rodolph Perfetta

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

ARM: Use VFP for non-Smi bitops results. This is basically Rodolph Perfettas change from http://codereview.chromium.org/2829032 with a tiny tweak to the unsigned shift right case. Committed: http://code.google.com/p/v8/source/detail?r=5012

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -11 lines)			Patch
	M	src/arm/codegen-arm.cc	View		3 chunks	+38 lines, -11 lines	0 comments	Download

Total messages: 4 (0 generated)

William Hesse

Are the negative offsets used anywhere? Maybe a unit test should be written. LGTM.

10 years, 5 months ago (2010-07-02 13:07:40 UTC) #2

Rodolph Perfetta

We intended to use negative offset, but didn't need them in the end.

10 years, 5 months ago (2010-07-02 13:13:48 UTC) #3

Committed without the negative offsets part.