Issue 2829032: Make use of VFP to convert/write 32bits int to heapnumbers. Extended...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2829032: Make use of VFP to convert/write 32bits int to heapnumbers. Extended... (Closed)

Created:
10 years, 5 months ago by Rodolph Perfetta

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make use of VFP to convert/write 32bits int to heapnumbers. Extended the assembler to support negative offset in vldr and vstr. BUG=none TEST=none

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -16 lines)			Patch
	M	src/arm/assembler-arm.cc	View		3 chunks	+30 lines, -6 lines	0 comments	Download
	M	src/arm/codegen-arm.cc	View		2 chunks	+29 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 5 months ago (2010-07-01 14:56:47 UTC) #2

LGTM, esp. if it makes things faster?

http://codereview.chromium.org/2829032/diff/1/3
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2829032/diff/1/3#newcode7915
src/arm/codegen-arm.cc:7915: // case.
If we have VFP3 we don't have to bail out here.  We can jump to result_not_a_smi
instead.  You just have to use a vcvt_f64_u32 instead of the signed one.

Expand Messages | Collapse Messages