Issue 2859042: Cleanup: remove use_existing_browser infrastructure from ui_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2859042: Cleanup: remove use_existing_browser infrastructure from ui_test. (Closed)

Created:
10 years, 5 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
huanr, Michael Williamson, Erik does not do reviews

CC:
chromium-reviews, Paweł Hajdan Jr.

Visibility:
Public.

Cleanup: remove use_existing_browser infrastructure from ui_test. It was Windows-only, probably broken, and unused. BUG=46135 TEST=ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51602

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -63 lines)			Patch
M	chrome/app/chrome_main_uitest.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/test/ui/ui_test.h	View	4 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View	8 chunks	+9 lines, -46 lines	0 comments	Download
M	chrome/test/ui/ui_test_suite.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Erik does not do reviews

My guess is that this was part of experiments to get ui tests working properly ...

10 years, 5 months ago (2010-07-02 14:37:40 UTC) #2

Michael Williamson

10 years, 5 months ago (2010-07-02 18:51:28 UTC) #3

LGTM.  Nice, should make future readers of the code less confused :).