Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5626)

Unified Diff: chrome/test/ui/ui_test.h

Issue 2859042: Cleanup: remove use_existing_browser infrastructure from ui_test. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_main_uitest.cc ('k') | chrome/test/ui/ui_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ui_test.h
diff --git a/chrome/test/ui/ui_test.h b/chrome/test/ui/ui_test.h
index 94148080b64c60cbd0395c01ec163b47b963ef1b..783f637ed2167dca990cc1e25aabcf4ae66a3b2e 100644
--- a/chrome/test/ui/ui_test.h
+++ b/chrome/test/ui/ui_test.h
@@ -350,11 +350,6 @@ class UITestBase {
full_memory_dump_ = value;
}
- static bool use_existing_browser() { return default_use_existing_browser_; }
- static void set_use_existing_browser(bool value) {
- default_use_existing_browser_ = value;
- }
-
static bool dump_histograms_on_exit() { return dump_histograms_on_exit_; }
static void set_dump_histograms_on_exit(bool value) {
dump_histograms_on_exit_ = value;
@@ -579,8 +574,6 @@ class UITestBase {
bool include_testing_id_; // Should we supply the testing channel
// id on the command line? Default is
// true.
- bool use_existing_browser_; // Duplicate of the static version.
- // Default value comes from static.
bool enable_file_cookies_; // Enable file cookies, default is true.
ProfileType profile_type_; // Are we using a profile with a
// complex theme?
@@ -590,7 +583,6 @@ class UITestBase {
private:
bool LaunchBrowserHelper(const CommandLine& arguments,
- bool use_existing_browser,
bool wait,
base::ProcessHandle* process);
@@ -607,8 +599,6 @@ class UITestBase {
// during crash.
static bool show_error_dialogs_; // If true, a user is paying attention
// to the test, so show error dialogs.
- static bool default_use_existing_browser_; // The test connects to an already
- // running browser instance.
static bool dump_histograms_on_exit_; // Include histograms in log on exit.
static bool enable_dcheck_; // Enable dchecks in release mode.
static bool silent_dump_on_dcheck_; // Dump process memory on dcheck without
« no previous file with comments | « chrome/app/chrome_main_uitest.cc ('k') | chrome/test/ui/ui_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698