Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2858064: Support object literal map caching for literals with keys that are array indi... (Closed)

Created:
10 years, 5 months ago by Vladislav Kaznacheev
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Support object literal map caching for literals with keys that are array indices. The caching code used to require that all keys in the literal were symbol strings in order to be able to cache object literal maps. Relaxed this requirement to allow array indices as well (as in { "1": "one", two: "two" }). Changed the way 'number_of_properties' is calculated so that redundant property slots are not allocated for array indices. Committed: http://code.google.com/p/v8/source/detail?r=5114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M src/runtime.cc View 1 chunk +28 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vladislav Kaznacheev
10 years, 5 months ago (2010-07-21 13:17:17 UTC) #1
Mads Ager (chromium)
10 years, 5 months ago (2010-07-22 06:07:27 UTC) #2
Excellent! LGTM

Powered by Google App Engine
This is Rietveld 408576698