Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2858018: Add a "session only" policy to the content settings. (Closed)

Created:
10 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, michaeln, jam+cc_chromium.org, cbentzel+watch_chromium.org, ben+cc_chromium.org, John Grabowski, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Add a "session only" policy to the content settings. session only is treated as allow, but the cookies will expire after this session (the actual code to expire non-html cookies will follow). BUG=47049 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/appcache/chrome_appcache_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/content_exceptions_window_controller.mm View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/content_exceptions_table_model.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/content_setting_combo_model.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/cookie_modal_dialog.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_area.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/net/chrome_cookie_policy.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/database_dispatcher_host.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/content_settings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
please review
10 years, 6 months ago (2010-06-21 11:30:35 UTC) #1
darin (slow to review)
10 years, 6 months ago (2010-06-21 16:29:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698