Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: chrome/browser/cookie_modal_dialog.cc

Issue 2858018: Add a "session only" policy to the content settings. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/content_setting_combo_model.cc ('k') | chrome/browser/in_process_webkit/dom_storage_area.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cookie_modal_dialog.cc
diff --git a/chrome/browser/cookie_modal_dialog.cc b/chrome/browser/cookie_modal_dialog.cc
index ed861785f18dab91cfe504e9c77894eef730ef09..08bf183edee14e932e62e8b8dc302a3905f81373 100644
--- a/chrome/browser/cookie_modal_dialog.cc
+++ b/chrome/browser/cookie_modal_dialog.cc
@@ -86,8 +86,9 @@ bool CookiePromptModalDialog::IsValid() {
origin_, CONTENT_SETTINGS_TYPE_COOKIES);
if (content_setting != CONTENT_SETTING_ASK) {
if (content_setting == CONTENT_SETTING_ALLOW) {
- // If it's remembered as allow, then we assume session_expire is false.
AllowSiteData(false, false);
+ } else if (content_setting == CONTENT_SETTING_SESSION_ONLY) {
+ AllowSiteData(false, true);
} else {
DCHECK(content_setting == CONTENT_SETTING_BLOCK);
BlockSiteData(false);
@@ -108,7 +109,8 @@ void CookiePromptModalDialog::AllowSiteData(bool remember,
CONTENT_SETTINGS_TYPE_COOKIES, CONTENT_SETTING_DEFAULT);
host_content_settings_map_->SetContentSetting(
HostContentSettingsMap::Pattern::FromURL(origin_),
- CONTENT_SETTINGS_TYPE_COOKIES, CONTENT_SETTING_ALLOW);
+ CONTENT_SETTINGS_TYPE_COOKIES,
+ session_expire ? CONTENT_SETTING_SESSION_ONLY : CONTENT_SETTING_ALLOW);
}
if (delegate_) {
« no previous file with comments | « chrome/browser/content_setting_combo_model.cc ('k') | chrome/browser/in_process_webkit/dom_storage_area.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698