Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2856070: Don't send machine and user ID to Omaha anymore. Send a/r pings instead. (Closed)

Created:
10 years, 4 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
Carl Nygaard, adlr
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Don't send machine and user ID to Omaha anymore. Send a/r pings instead. This avoids sending a unique ID in order to track active user counts. Note that this CL doesn't remove the machine/user/Omaha ID/file from the params object -- it just makes them unused/obsolete. Removal will be done in a subsequent CL in an effort to make this CL smaller. BUG=1439 TEST=unit tests, x86-generic, arm-generic, gmerged and inspected logs

Patch Set 1 #

Patch Set 2 : Remove copy/pasted comments. #

Total comments: 12

Patch Set 3 : Address review comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+478 lines, -258 lines) Patch
M SConstruct View 1 chunk +1 line, -1 line 0 comments Download
M main.cc View 2 chunks +7 lines, -1 line 0 comments Download
M omaha_request_action.h View 5 chunks +24 lines, -1 line 1 comment Download
M omaha_request_action.cc View 1 2 7 chunks +131 lines, -15 lines 0 comments Download
M omaha_request_action_unittest.cc View 1 2 23 chunks +261 lines, -230 lines 0 comments Download
M prefs.h View 2 chunks +4 lines, -0 lines 0 comments Download
M prefs.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M prefs_interface.h View 2 chunks +5 lines, -0 lines 0 comments Download
A prefs_mock.h View 1 chunk +24 lines, -0 lines 0 comments Download
M prefs_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M update_attempter.h View 2 chunks +5 lines, -1 line 0 comments Download
M update_attempter.cc View 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
petkov
10 years, 4 months ago (2010-07-28 23:34:08 UTC) #1
adlr
http://codereview.chromium.org/2856070/diff/2001/3003 File omaha_request_action.cc (right): http://codereview.chromium.org/2856070/diff/2001/3003#newcode193 omaha_request_action.cc:193: string request_post(FormatRequest(event_.get(), params_, ping_active_days_, one arg per line, i ...
10 years, 4 months ago (2010-07-29 00:41:14 UTC) #2
petkov
http://codereview.chromium.org/2856070/diff/2001/3003 File omaha_request_action.cc (right): http://codereview.chromium.org/2856070/diff/2001/3003#newcode193 omaha_request_action.cc:193: string request_post(FormatRequest(event_.get(), params_, ping_active_days_, On 2010/07/29 00:41:14, adlr wrote: ...
10 years, 4 months ago (2010-07-29 17:11:29 UTC) #3
petkov
PTAL
10 years, 4 months ago (2010-07-29 17:11:41 UTC) #4
adlr
LGTM
10 years, 4 months ago (2010-07-29 19:20:02 UTC) #5
Carl Nygaard
LGTM All the days since logic looks correct to me. Great tests too. http://codereview.chromium.org/2856070/diff/8001/7005 File ...
10 years, 4 months ago (2010-07-29 21:02:53 UTC) #6
petkov
On 2010/07/29 21:02:53, Carl Nygaard wrote: > LGTM Thanks much for looking. I've added to ...
10 years, 4 months ago (2010-07-29 21:09:47 UTC) #7
petkov
10 years, 4 months ago (2010-07-29 21:10:45 UTC) #8
On 2010/07/29 21:09:47, petkov wrote:
> On 2010/07/29 21:02:53, Carl Nygaard wrote:
> > LGTM
> 
> Thanks much for looking. I've added to typo fix to
> http://codereview.chromium.org/2856070/show.

I meant: http://codereview.chromium.org/2808082/show.

> 
> > 
> > All the days since logic looks correct to me.  Great tests too.
> > 
> > http://codereview.chromium.org/2856070/diff/8001/7005
> > File omaha_request_action.h (right):
> > 
> > http://codereview.chromium.org/2856070/diff/8001/7005#newcode148
> > omaha_request_action.h:148: // Based on the perstitent preference store
> values,
> > calculates the
> > perstitent -> persistent

Powered by Google App Engine
This is Rietveld 408576698