Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: omaha_request_action.h

Issue 2856070: Don't send machine and user ID to Omaha anymore. Send a/r pings instead. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git
Patch Set: Address review comments. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « main.cc ('k') | omaha_request_action.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: omaha_request_action.h
diff --git a/omaha_request_action.h b/omaha_request_action.h
index b487a3bc3f1be6e4c95b3880acc521e7bc17236d..c5f4d19914ccdd59d41e7f5cb9268b2267a44832 100644
--- a/omaha_request_action.h
+++ b/omaha_request_action.h
@@ -85,6 +85,7 @@ struct OmahaEvent {
class NoneType;
class OmahaRequestAction;
struct OmahaRequestParams;
+class PrefsInterface;
template<>
class ActionTraits<OmahaRequestAction> {
@@ -99,6 +100,9 @@ class ActionTraits<OmahaRequestAction> {
class OmahaRequestAction : public Action<OmahaRequestAction>,
public HttpFetcherDelegate {
public:
+ static const int kNeverPinged = -1;
+ static const int kPingTimeJump = -2;
+
// The ctor takes in all the parameters that will be used for making
// the request to Omaha. For some of them we have constants that
// should be used.
@@ -113,7 +117,8 @@ class OmahaRequestAction : public Action<OmahaRequestAction>,
// OmahaRequestAction(..., new OmahaEvent(...), new WhateverHttpFetcher);
// or
// OmahaRequestAction(..., NULL, new WhateverHttpFetcher);
- OmahaRequestAction(const OmahaRequestParams& params,
+ OmahaRequestAction(PrefsInterface* prefs,
+ const OmahaRequestParams& params,
OmahaEvent* event,
HttpFetcher* http_fetcher);
virtual ~OmahaRequestAction();
@@ -135,6 +140,18 @@ class OmahaRequestAction : public Action<OmahaRequestAction>,
bool IsEvent() const { return event_.get() != NULL; }
private:
+ // If this is an update check request, initializes
+ // |ping_active_days_| and |ping_roll_call_days_| to values that may
+ // be sent as pings to Omaha.
+ void InitPingDays();
+
+ // Based on the perstitent preference store values, calculates the
Carl Nygaard 2010/07/29 21:02:53 perstitent -> persistent
+ // number of days since the last ping sent for |key|.
+ int CalculatePingDays(const std::string& key);
+
+ // Access to the preferences store.
+ PrefsInterface* prefs_;
+
// These are data that are passed in the request to the Omaha server.
const OmahaRequestParams& params_;
@@ -147,6 +164,12 @@ class OmahaRequestAction : public Action<OmahaRequestAction>,
// Stores the response from the omaha server
std::vector<char> response_buffer_;
+ // Initialized by InitPingDays to values that may be sent to Omaha
+ // as part of a ping message. Note that only positive values and -1
+ // are sent to Omaha.
+ int ping_active_days_;
+ int ping_roll_call_days_;
+
DISALLOW_COPY_AND_ASSIGN(OmahaRequestAction);
};
« no previous file with comments | « main.cc ('k') | omaha_request_action.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698