[Mac] Center image in keyword-search and ev bubble in omnibox.

[Mac] Center image in keyword-search and ev bubble in omnibox.

Omnibox recently got taller on Mac, which screwed up the centering.
Visually inspect and re-center.

BUG=49101
TEST=https://www.thawte.com/, lock should be centered vertically.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52439

[Scott Hess - ex-Googler, 2010-07-15 00:34:08]

Redirecting at John so that I can save Rohit for changes he's most relevant to
review.

[John Grabowski, 2010-07-15 00:39:38]

LGTM

http://codereview.chromium.org/2856037/diff/1/2
File chrome/browser/cocoa/location_bar/bubble_decoration.mm (left):

http://codereview.chromium.org/2856037/diff/1/2#oldcode16
chrome/browser/cocoa/location_bar/bubble_decoration.mm:16: const CGFloat
kImageInset = 3.0;
If inset is now 0, perhaps you can remove this variable and all references to
it?

[Scott Hess - ex-Googler, 2010-07-15 04:07:38]

http://codereview.chromium.org/2856037/diff/1/2
File chrome/browser/cocoa/location_bar/bubble_decoration.mm (left):

http://codereview.chromium.org/2856037/diff/1/2#oldcode16
chrome/browser/cocoa/location_bar/bubble_decoration.mm:16: const CGFloat
kImageInset = 3.0;
On 2010/07/15 00:39:38, John Grabowski wrote:
> If inset is now 0, perhaps you can remove this variable and all references to
> it?

OK.  I was going to say "What if things change again?", but then decided that if
that happens, maybe it could just be calculated dynamically and never have to
visit it again.  Though that's probably wishful thinking.