[Mac] Center image in keyword-search and ev bubble in omnibox.

chrome/browser/cocoa/location_bar/bubble_decoration.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/location_bar/bubble_decoration.h"
 
 #include "base/logging.h"
 #import "chrome/browser/cocoa/image_utils.h"
 
 namespace {
 
 // Padding between the icon/label and bubble edges.
 const CGFloat kBubblePadding = 7.0;
 
 // How far to inset image from boundary rect.
-const CGFloat kImageInset = 3.0;

[John Grabowski, 2010/07/15 00:39:38]

If inset is now 0, perhaps you can remove this variable and all references to
it?

[Scott Hess - ex-Googler, 2010/07/15 04:07:38]

OK.  I was going to say "What if things change again?", but then decided that if
that happens, maybe it could just be calculated dynamically and never have to
visit it again.  Though that's probably wishful thinking.

+const CGFloat kImageInset = 0.0;
 
 // How far to inset the keywork token from sides.
 const NSInteger kKeywordYInset = 4;
 
 }  // namespace
 
 BubbleDecoration::BubbleDecoration(NSFont* font) {
   DCHECK(font);
   if (font) {
     NSDictionary* attributes =
@@ skipping 80 matching lines @@
     label_.reset([label copy]);
 }
 
 void BubbleDecoration::SetColors(NSColor* border_color,
                                  NSColor* background_color,
                                  NSColor* text_color) {
   border_color_.reset([border_color retain]);
   background_color_.reset([background_color retain]);
   text_color_.reset([text_color retain]);
 }