[Mac] force -Wextra on for all chromium code. Not bothering with a local swi...

build/common.gypi

Index: build/common.gypi
===================================================================
--- build/common.gypi	(revision 50344)
+++ build/common.gypi	(working copy)
@@ -166,10 +166,6 @@
     'mac_sdk%': '10.5',
     'mac_deployment_target%': '10.5',
 
-    # Turn on -Wextra on chromium code during Mac compile.
-    # TODO(mark,tvl): drop this and turn it always on when it works.
-    'chromium_mac_wextra%': 0,
-
     # Set to 1 to enable code coverage.  In addition to build changes
     # (e.g. extra CFLAGS), also creates a new target in the src/chrome
     # project file called "coverage".
@@ -1146,21 +1142,20 @@
           'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)',
           'PREBINDING': 'NO',                       # No -Wl,-prebind
           'USE_HEADERMAP': 'NO',
-          'WARNING_CFLAGS': ['-Wall', '-Wendif-labels'],
+          'WARNING_CFLAGS': [
+            '-Wall',
+            '-Wendif-labels',

[Evan Martin, 2010/06/21 20:34:57]

FWIW, according to http://gcc.gnu.org/onlinedocs/cpp/Invocation.html "This
warning is on by default."

+            '-Wextra',
+            # Don't warn about unused function params.  Used everywhere.

[Mark Mentovai, 2010/06/21 13:48:23]

params -> parameters.

“Used everywhere” means that -Wno-unused-parameter is used everywhere, or unused
function parameters are used everywhere?

+            '-Wno-unused-parameter',
+            # Don't warn about the "struct foo f = {0};" initialization
+            # pattern.
+            '-Wno-missing-field-initializers',
+          ],
           'conditions': [
             ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'},
                                  {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'}
             ],
-            ['chromium_mac_wextra', {
-              'WARNING_CFLAGS': [
-                '-Wextra',
-                # Don't warn about unused function params.  Used everywhere.
-                '-Wno-unused-parameter',
-                # Don't warn about the "struct foo f = {0};" initialization
-                # pattern.
-                '-Wno-missing-field-initializers',
-              ]
-            }],
           ],
         },
         'target_conditions': [