[Mac] force -Wextra on for all chromium code. Not bothering with a local swi...

build/common.gypi

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   'variables': {
     # .gyp files or targets should set chromium_code to 1 if they build
@@ skipping 148 matching lines @@
     # MAC_OS_X_VERSION_MIN_REQUIRED compile-time macro.
     # To ensure these macros are available, #include <AvailabilityMacros.h>.
     # Additional documentation on these macros is available at
     # http://developer.apple.com/mac/library/technotes/tn2002/tn2064.html#SECTION3
     # Chrome normally builds with the Mac OS X 10.5 SDK and sets the
     # deployment target to 10.5.  Other projects, such as O3D, may override
     # these defaults.
     'mac_sdk%': '10.5',
     'mac_deployment_target%': '10.5',
 
-    # Turn on -Wextra on chromium code during Mac compile.
-    # TODO(mark,tvl): drop this and turn it always on when it works.
-    'chromium_mac_wextra%': 0,
-
     # Set to 1 to enable code coverage.  In addition to build changes
     # (e.g. extra CFLAGS), also creates a new target in the src/chrome
     # project file called "coverage".
     # Currently ignored on Windows.
     'coverage%': 0,
 
     # Overridable specification for potential use of alternative
     # JavaScript engines.
     'javascript_engine%': 'v8',
 
@@ skipping 956 matching lines @@
           'GCC_OBJC_CALL_CXX_CDTORS': 'YES',        # -fobjc-call-cxx-cdtors
           'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',      # -fvisibility=hidden
           'GCC_THREADSAFE_STATICS': 'NO',           # -fno-threadsafe-statics
           'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES',    # -Werror
           'GCC_VERSION': '4.2',
           'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES',  # -Wnewline-eof
           # MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min
           'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)',
           'PREBINDING': 'NO',                       # No -Wl,-prebind
           'USE_HEADERMAP': 'NO',
-          'WARNING_CFLAGS': ['-Wall', '-Wendif-labels'],
+          'WARNING_CFLAGS': [
+            '-Wall',
+            '-Wendif-labels',

[Evan Martin, 2010/06/21 20:34:57]

FWIW, according to http://gcc.gnu.org/onlinedocs/cpp/Invocation.html "This
warning is on by default."

+            '-Wextra',
+            # Don't warn about unused function params.  Used everywhere.

[Mark Mentovai, 2010/06/21 13:48:23]

params -> parameters.

“Used everywhere” means that -Wno-unused-parameter is used everywhere, or unused
function parameters are used everywhere?

+            '-Wno-unused-parameter',
+            # Don't warn about the "struct foo f = {0};" initialization
+            # pattern.
+            '-Wno-missing-field-initializers',
+          ],
           'conditions': [
             ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'},
                                  {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'}
             ],
-            ['chromium_mac_wextra', {
-              'WARNING_CFLAGS': [
-                '-Wextra',
-                # Don't warn about unused function params.  Used everywhere.
-                '-Wno-unused-parameter',
-                # Don't warn about the "struct foo f = {0};" initialization
-                # pattern.
-                '-Wno-missing-field-initializers',
-              ]
-            }],
           ],
         },
         'target_conditions': [
           ['_type!="static_library"', {
             'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']},
           }],
           ['_mac_bundle', {
             'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},
           }],
           ['_type=="executable" or _type=="shared_library" or _type=="loadable_module"', {
@@ skipping 219 matching lines @@
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: