Issue 2854013: [Mac] force -Wextra on for all chromium code. Not bothering with a local swi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2854013: [Mac] force -Wextra on for all chromium code. Not bothering with a local swi... (Closed)

Created:
10 years, 6 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Evan Martin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] force -Wextra on for all chromium code. Not bothering with a local switch since there shouldn't be a reason to allow overrides of this. BUG=34160 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50355

Patch Set 1 #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -15 lines)			Patch
	M	build/common.gypi	View		2 chunks	+10 lines, -15 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

lg http://codereview.chromium.org/2854013/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/2854013/diff/1/2#newcode1149 build/common.gypi:1149: # Don't warn about unused function params. Used ...

10 years, 6 months ago (2010-06-21 13:48:23 UTC) #2

Evan Martin

10 years, 6 months ago (2010-06-21 20:34:56 UTC) #3

http://codereview.chromium.org/2854013/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/2854013/diff/1/2#newcode1147
build/common.gypi:1147: '-Wendif-labels',
FWIW, according to http://gcc.gnu.org/onlinedocs/cpp/Invocation.html "This
warning is on by default."

Expand Messages | Collapse Messages