Issue 2852024: Chromium side changes to use PP_CompletionCallback as the Flush callback....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2852024: Chromium side changes to use PP_CompletionCallback as the Flush callback.... (Closed)

Created:
10 years, 6 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Chromium side changes to use PP_CompletionCallback as the Flush callback. R=brettw BUG=47461 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50851

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -54 lines)			Patch
M	DEPS	View	3	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/client/plugin/chromoting_plugin.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/pepper_device_context_2d.h	View		4 chunks	+26 lines, -10 lines	0 comments	Download
M	webkit/glue/plugins/pepper_device_context_2d.cc	View	1	8 chunks	+28 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

This CL depends on http://codereview.chromium.org/2853015

10 years, 6 months ago (2010-06-24 23:32:57 UTC) #2

brettw

10 years, 6 months ago (2010-06-25 04:03:44 UTC) #3

LGTM

On Thu, Jun 24, 2010 at 4:32 PM,  <darin@chromium.org> wrote:
> This CL depends on http://codereview.chromium.org/2853015
>
> http://codereview.chromium.org/2852024/show
>

Expand Messages | Collapse Messages