Issue 2853015: Switch FlushCallback to be a PP_CompletionCallback....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2853015: Switch FlushCallback to be a PP_CompletionCallback.... (Closed)

Created:
10 years, 6 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
http://ppapi.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Switch FlushCallback to be a PP_CompletionCallback. R=brettw BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -35 lines)			Patch
M	c/pp_errors.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	c/ppb_device_context_2d.h	View	1	2 chunks	+10 lines, -12 lines	0 comments	Download
M	cpp/device_context_2d.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	cpp/device_context_2d.cc	View		2 chunks	+10 lines, -5 lines	0 comments	Download
M	example/example.cc	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/test_device_context_2d.cc	View	1 2	6 chunks	+27 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

10 years, 6 months ago (2010-06-25 04:03:05 UTC) #3

LGTM

I noticed something, "WouldBlock" means "I scheduled what you asked and am
returning" but it sounds instead like an error ("you can't do this now because
it would block". I wonder if WillCompleteAsync or something like that would be
an easier name for people to understand.

Expand Messages | Collapse Messages