Issue 2846038: Add UMA logging of search engine selection position when the search engine lo...

Issue 2846038: Add UMA logging of search engine selection position when the search engine lo... (Closed)

Created:
10 years, 6 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
GeorgeY

CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add UMA logging of search engine selection position when the search engine logo positions have been randomized. BUG=46604 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51061

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -10 lines)			Patch
M	chrome/browser/browser_main.cc	View	1 2	2 chunks	+20 lines, -2 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_model.h	View	1 2 3	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/views/first_run_search_engine_view.h	View	1 2 3	5 chunks	+14 lines, -6 lines	0 comments	Download
M	chrome/browser/views/first_run_search_engine_view.cc	View	1 2 3	2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

GeorgeY

LGTM, with two comments. http://codereview.chromium.org/2846038/diff/25001/26002 File chrome/browser/search_engines/template_url_model.h (right): http://codereview.chromium.org/2846038/diff/25001/26002#newcode226 chrome/browser/search_engines/template_url_model.h:226: int GetSearchEngineDialogSlot() { int GetSearchEngineDialogSlot() ...

10 years, 5 months ago (2010-06-28 21:14:58 UTC) #3

Miranda Callahan

10 years, 5 months ago (2010-06-28 22:50:56 UTC) #4

http://codereview.chromium.org/2846038/diff/25001/26002
File chrome/browser/search_engines/template_url_model.h (right):

http://codereview.chromium.org/2846038/diff/25001/26002#newcode226
chrome/browser/search_engines/template_url_model.h:226: int
GetSearchEngineDialogSlot() {
On 2010/06/28 21:14:58, GeorgeY wrote:
> int GetSearchEngineDialogSlot() const {

Done.

http://codereview.chromium.org/2846038/diff/25001/26004
File chrome/browser/views/first_run_search_engine_view.h (right):

http://codereview.chromium.org/2846038/diff/25001/26004#newcode57
chrome/browser/views/first_run_search_engine_view.h:57: int GetSlot() { return
slot_; }
oh, good point.  done.

Expand Messages | Collapse Messages