Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: chrome/browser/views/first_run_search_engine_view.h

Issue 2846038: Add UMA logging of search engine selection position when the search engine lo... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/first_run_search_engine_view.h
===================================================================
--- chrome/browser/views/first_run_search_engine_view.h (revision 50982)
+++ chrome/browser/views/first_run_search_engine_view.h (working copy)
@@ -52,6 +52,10 @@
// Accessor for the search engine data this button represents.
const TemplateURL* GetSearchEngine() { return search_engine_; }
+ // Used for UX testing.
+ void set_slot(int slot) { slot_ = slot; }
+ int slot() const { return slot_; }
+
private:
// Either an ImageView of a logo, or a Label with text. Owned by
// FirstRunSearchEngineView.
@@ -63,6 +67,9 @@
// Data for the search engine held here.
const TemplateURL* search_engine_;
+ // Used for UX testing. Gives slot in which search engine was shown.
+ int slot_;
+
DISALLOW_COPY_AND_ASSIGN(SearchEngineChoice);
};
@@ -83,9 +90,10 @@
public TemplateURLModelObserver {
public:
// |observer| is the FirstRunView that waits for us to pass back a search
- // engine choice; |profile| allows us to get the set of imported search
- // engines, and display the KeywordEditorView on demand; |randomize|
- // is true if logos are to be displayed in random order.
+ // engine choice.
+ // |profile| allows us to get the set of imported search engines, and
+ // display the KeywordEditorView on demand.
+ // |randomize| is true if logos are to be displayed in random order.
FirstRunSearchEngineView(SearchEngineSelectionObserver* observer,
Profile* profile, bool randomize);
@@ -121,6 +129,9 @@
// One for each search engine choice offered, either three or four.
std::vector<SearchEngineChoice*> search_engine_choices_;
+ // If logos are to be displayed in random order. Used for UX testing.
+ bool randomize_;
+
// The profile associated with this import process.
Profile* profile_;
@@ -129,9 +140,6 @@
bool text_direction_is_rtl_;
- // If logos are to be displayed in random order. Used for UX testing.
- bool randomize_;
-
// Image of browser search box with grey background and bubble arrow.
views::ImageView* background_image_;
« no previous file with comments | « chrome/browser/search_engines/template_url_model.h ('k') | chrome/browser/views/first_run_search_engine_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698