Issue 2846034: Split out the bookmark permission into its own line in ExtensionInstallUI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2846034: Split out the bookmark permission into its own line in ExtensionInstallUI. (Closed)

Created:
10 years, 6 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Split out the bookmark permission into its own line in ExtensionInstallUI. Also, fix a bug where a change to the geolocation permission wasn't triggering the privilege increase path and refactor code to try and reduce the chance of that kind of bug in the future. BUG=45715 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50916

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -7 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	3 chunks	+23 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

10 years, 6 months ago (2010-06-25 20:34:02 UTC) #2

LGTM, but my concern still stands that tabs->bookmarks shouldn't be considered a
privilege increase.

Expand Messages | Collapse Messages