Chromium Code Reviews

Unified Diff: chrome/browser/extensions/extension_install_ui.cc

Issue 2846034: Split out the bookmark permission into its own line in ExtensionInstallUI. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_install_ui.cc
diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc
index 1c9680f4f2a31a584f0375d4d90e0ddffddd9990..0ee4cb8058d45a52af0a2b1613eed9729ed32e4e 100644
--- a/chrome/browser/extensions/extension_install_ui.cc
+++ b/chrome/browser/extensions/extension_install_ui.cc
@@ -109,12 +109,15 @@ static void GetV2Warnings(Extension* extension,
IDS_EXTENSION_PROMPT2_WARNING_BROWSING_HISTORY));
}
- if (extension->HasApiPermission(Extension::kGeolocationPermission)) {
- warnings->push_back(l10n_util::GetStringUTF16(
- IDS_EXTENSION_PROMPT2_WARNING_GEOLOCATION));
+ const Extension::SimplePermissions& simple_permissions =
+ Extension::GetSimplePermissions();
+
+ for (Extension::SimplePermissions::const_iterator iter =
+ simple_permissions.begin();
+ iter != simple_permissions.end(); ++iter) {
+ if (extension->HasApiPermission(iter->first))
+ warnings->push_back(iter->second);
}
-
- // TODO(aa): camera/mic, what else?
}
} // namespace
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »

Powered by Google App Engine