Issue 2843051: Use --official_build boolean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2843051: Use --official_build boolean. (Closed)

Created:
10 years, 5 months ago by djmm

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Use --official_build boolean.

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	upload_symbols	View		3 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 5 months ago (2010-07-07 19:44:08 UTC) #2

LGTM

On Wed, Jul 7, 2010 at 12:20 PM,  <djmm@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Use --official_build boolean.
>
> Please review this at http://codereview.chromium.org/2843051/show
>
> SVN Base: ssh://git@chromiumos-git/crosutils.git
>
> Affected files:
>  M upload_symbols
>
>
> Index: upload_symbols
> diff --git a/upload_symbols b/upload_symbols
> index
>
2f48aea4f218eca9d9dfd3eab900359e67e9b76f..709b0fedb37c82cad8e3753dbd1f2a036094019f
> 100755
> --- a/upload_symbols
> +++ b/upload_symbols
> @@ -24,6 +24,7 @@ get_default_board
>  DEFINE_string board "$DEFAULT_BOARD" "The board to build packages for."
>  DEFINE_boolean dryrun ${FLAGS_FALSE} "Run without actually uploading."
>  DEFINE_boolean verbose ${FLAGS_FALSE} "Be verbose."
> +DEFINE_boolean official_build $FLAGS_FALSE "Point to official symbol
> server."
>  DEFINE_boolean yes ${FLAGS_FALSE} "Answer yes to all prompts."
>
>  DUMP_SYMS="dump_syms.i386"
> @@ -39,14 +40,6 @@ function cleanup() {
>   rm -f "${SYM_FILE}" "${ERR_FILE}"
>  }
>
> -function is_official() {
> -  if [ ${CHROMEOS_OFFICIAL:-0} = 1 ]; then
> -    return 0
> -  else
> -    return 1
> -  fi
> -}
> -
>  # Given path to a debug file, return its text file
>  function get_text_for_debug {
>   local debug_file=$1
> @@ -193,7 +186,7 @@ function main() {
>
>   local upload_url=""
>   if [ ${FLAGS_dryrun} -eq ${FLAGS_FALSE} ]; then
> -    if is_official; then
> +    if [ $FLAGS_official_build -eq $FLAGS_TRUE ]; then
>       upload_url="http://clients2.google.com/cr/symbol"
>     else
>       upload_url="http://clients2.google.com/cr/staging_symbol"
>
>
>

Expand Messages | Collapse Messages