Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: upload_symbols

Issue 2843051: Use --official_build boolean. (Closed) Base URL: ssh://git@chromiumos-git/crosutils.git
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: upload_symbols
diff --git a/upload_symbols b/upload_symbols
index 2f48aea4f218eca9d9dfd3eab900359e67e9b76f..709b0fedb37c82cad8e3753dbd1f2a036094019f 100755
--- a/upload_symbols
+++ b/upload_symbols
@@ -24,6 +24,7 @@ get_default_board
DEFINE_string board "$DEFAULT_BOARD" "The board to build packages for."
DEFINE_boolean dryrun ${FLAGS_FALSE} "Run without actually uploading."
DEFINE_boolean verbose ${FLAGS_FALSE} "Be verbose."
+DEFINE_boolean official_build $FLAGS_FALSE "Point to official symbol server."
DEFINE_boolean yes ${FLAGS_FALSE} "Answer yes to all prompts."
DUMP_SYMS="dump_syms.i386"
@@ -39,14 +40,6 @@ function cleanup() {
rm -f "${SYM_FILE}" "${ERR_FILE}"
}
-function is_official() {
- if [ ${CHROMEOS_OFFICIAL:-0} = 1 ]; then
- return 0
- else
- return 1
- fi
-}
-
# Given path to a debug file, return its text file
function get_text_for_debug {
local debug_file=$1
@@ -193,7 +186,7 @@ function main() {
local upload_url=""
if [ ${FLAGS_dryrun} -eq ${FLAGS_FALSE} ]; then
- if is_official; then
+ if [ $FLAGS_official_build -eq $FLAGS_TRUE ]; then
upload_url="http://clients2.google.com/cr/symbol"
else
upload_url="http://clients2.google.com/cr/staging_symbol"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698