Issue 2842059: Revert 52872 - Remove the special hole that was opened for Native Client...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2842059: Revert 52872 - Remove the special hole that was opened for Native Client... (Closed)

Created:
10 years, 5 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
Mark Schneckloth

CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 52872 - Remove the special hole that was opened for Native Client in order for it to do bind() and connect(). BUG=http://code.google.com/p/chromium/issues/detail?id=26781 TEST=all tests pass, especially nacl_ui_tests Review URL: http://codereview.chromium.org/2881016 TBR=msneck@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52878

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	chrome/browser/nacl_loader.sb	View		1 chunk	+11 lines, -0 lines	0 comments	Download
	M	chrome/renderer/renderer.sb	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM.