Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2881016: Remove the special hole that was opened for Native Client... (Closed)

Created:
10 years, 5 months ago by Mark Schneckloth
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Remove the special hole that was opened for Native Client in order for it to do bind() and connect(). BUG=http://code.google.com/p/chromium/issues/detail?id=26781 TEST=all tests pass, especially nacl_ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M chrome/browser/nacl_loader.sb View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/renderer/renderer.sb View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Schneckloth
This change closes the Native Client hole in the Mac sandbox, but it cannot be ...
10 years, 5 months ago (2010-07-15 23:00:35 UTC) #1
Mark Schneckloth
Oh, I'll be creating another CL to remove the C++ code that dealt with the ...
10 years, 5 months ago (2010-07-15 23:06:29 UTC) #2
John Grabowski
LGTM from me! Negative code FTW!
10 years, 5 months ago (2010-07-15 23:19:11 UTC) #3
Amanda Walker
LGTM!
10 years, 5 months ago (2010-07-16 02:27:55 UTC) #4
jeremy
10 years, 5 months ago (2010-07-16 05:08:04 UTC) #5
LGTM
Thanks for following up on this!

On Fri, Jul 16, 2010 at 5:27 AM, Amanda Walker <amanda@chromium.org> wrote:

> LGTM!
>
>

Powered by Google App Engine
This is Rietveld 408576698