Issue 2836073: [Mac] Fix a crashing PreferencesWindowController unit test (only crashes in b...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2836073: [Mac] Fix a crashing PreferencesWindowController unit test (only crashes in b... (Closed)

Created:
10 years, 4 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, akalin

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

[Mac] Fix a crashing PreferencesWindowController unit test (only crashes in branded builds). BUG=50471 TEST=PreferencesWindowController.SwitchToPage should not crash in official builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54160

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/preferences_window_controller.mm	View		2 chunks	+10 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

rohitrao (ping after 24h)

The branded unit test is unhappy without a local state object, so let's give it ...

10 years, 4 months ago (2010-07-28 23:35:45 UTC) #1

akalin

10 years, 4 months ago (2010-07-29 00:12:11 UTC) #3

LGTM

On 2010/07/29 00:05:11, John Grabowski wrote:
> LGTM
> 
> +1 for initiative