[Mac] Fix a crashing PreferencesWindowController unit test (only crashes in b...

chrome/browser/cocoa/preferences_window_controller.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/preferences_window_controller.h"
 
 #include <algorithm>
 
 #include "app/l10n_util.h"
 #include "app/l10n_util_mac.h"
@@ skipping 374 matching lines @@
 };
 
 // Tracks state for a managed prefs banner and triggers UI updates through the
 // PreferencesWindowController as appropriate.
 class ManagedPrefsBannerState : public ManagedPrefsBannerBase {
  public:
   virtual ~ManagedPrefsBannerState() { }
 
   explicit ManagedPrefsBannerState(PreferencesWindowController* controller,
                                    OptionsPage page,
+                                   PrefService* local_state,
                                    PrefService* prefs)
-      : ManagedPrefsBannerBase(prefs, page),
+    : ManagedPrefsBannerBase(local_state, prefs, page),
         controller_(controller),
         page_(page) { }
 
   BOOL IsVisible() {
     return DetermineVisibility();
   }
 
  protected:
   // Overridden from ManagedPrefsBannerBase.
   virtual void OnUpdateVisibility() {
@@ skipping 1546 matching lines @@
 - (void)animationDidEnd:(NSAnimation*)animation {
   DCHECK_EQ(animation_.get(), animation);
   // Animation finished, reset subviews to current prefs view and the banner.
   [self resetSubViews];
 }
 
 // Reinitializes the banner state tracker object to watch for managed bits of
 // preferences relevant to the given options |page|.
 - (void)initBannerStateForPage:(OptionsPage)page {
   page = [self normalizePage:page];
+
+  // During unit tests, there is no local state object, so we fall back to
+  // the prefs object (where we've explicitly registered this pref so we
+  // know it's there).
+  PrefService* local = g_browser_process->local_state();
+  if (!local)
+    local = prefs_;
   bannerState_.reset(
       new PreferencesWindowControllerInternal::ManagedPrefsBannerState(
-          self, page, prefs_));
+          self, page, local, prefs_));
 }
 
 - (void)switchToPage:(OptionsPage)page animate:(BOOL)animate {
   [self displayPreferenceViewForPage:page animate:animate];
   NSToolbarItem* toolbarItem = [self getToolbarItemForPage:page];
   [toolbar_ setSelectedItemIdentifier:[toolbarItem itemIdentifier]];
 }
 
 // Called when the window is being closed. Send out a notification that the user
 // is done editing preferences. Make sure there are no pending field editors
@@ skipping 90 matching lines @@
     case OPTIONS_PAGE_ADVANCED:
       return underTheHoodView_;
     case OPTIONS_PAGE_DEFAULT:
     case OPTIONS_PAGE_COUNT:
       LOG(DFATAL) << "Invalid page value " << page;
   }
   return basicsView_;
 }
 
 @end