Issue 2836032: Use InvalidationClient::Create() instead of creating an Impl directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2836032: Use InvalidationClient::Create() instead of creating an Impl directly. (Closed)

Created:
10 years, 5 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Visibility:
Public.

Description

Use InvalidationClient::Create() instead of creating an Impl directly. BUG=34647 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51140

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -10 lines)			Patch
M	chrome/browser/sync/notifier/chrome_invalidation_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/notifier/chrome_invalidation_client.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/notifier/server_notifier_thread.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

LGTM. I thought I already LGTMed the changes to server_notifier_thread.cc?

10 years, 5 months ago (2010-06-29 14:40:05 UTC) #2

akalin

10 years, 5 months ago (2010-06-29 17:25:29 UTC) #3

On 2010/06/29 14:40:05, ncarter wrote:
> LGTM.
> 
> I thought I already LGTMed the changes to server_notifier_thread.cc?

That was changing the constant; this is changing the variable name.

Expand Messages | Collapse Messages