Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: chrome/browser/sync/notifier/server_notifier_thread.cc

Issue 2836032: Use InvalidationClient::Create() instead of creating an Impl directly. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/notifier/chrome_invalidation_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/notifier/server_notifier_thread.cc
diff --git a/chrome/browser/sync/notifier/server_notifier_thread.cc b/chrome/browser/sync/notifier/server_notifier_thread.cc
index f52df43f2023f7124ac68eb880cd051df2e8c40f..81ac612e753a77608f3f2d57ced26a69e91d76ee 100644
--- a/chrome/browser/sync/notifier/server_notifier_thread.cc
+++ b/chrome/browser/sync/notifier/server_notifier_thread.cc
@@ -110,12 +110,12 @@ void ServerNotifierThread::StartInvalidationListener() {
StopInvalidationListener();
chrome_invalidation_client_.reset(new ChromeInvalidationClient());
- // TODO(akalin): Make cache_guid() part of the app name. If we do
+ // TODO(akalin): Make cache_guid() part of the client ID. If we do
// so and we somehow propagate it up to the server somehow, we can
// make it so that we won't receive any notifications that were
// generated from our own changes.
- const std::string kAppName = "server_notifier_thread";
- chrome_invalidation_client_->Start(kAppName, this, xmpp_client());
+ const std::string kClientId = "server_notifier_thread";
+ chrome_invalidation_client_->Start(kClientId, this, xmpp_client());
}
void ServerNotifierThread::RegisterTypesAndSignalSubscribed() {
« no previous file with comments | « chrome/browser/sync/notifier/chrome_invalidation_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698