Issue 2835042: Don't instantiate an ExtensionPrefStore....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2835042: Don't instantiate an ExtensionPrefStore.... (Closed)

Created:
10 years, 5 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't instantiate an ExtensionPrefStore. It's not needed yet (no extensions use it), and it has memory leaks. BUG=48980 TEST=valgrind and heapcheck don't trigger the suppressions for this bug anymore Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52865

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/pref_service.cc	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

I don't know why the patch isn't applying on the tryservers. I'll get that sorted ...

10 years, 5 months ago (2010-07-16 16:23:22 UTC) #1

Bernhard Bauer

LGTM. On 2010/07/16 16:23:22, Pam wrote: > I don't know why the patch isn't applying ...

10 years, 5 months ago (2010-07-16 16:27:41 UTC) #2

Pam (message me for reviews)

10 years, 5 months ago (2010-07-16 16:36:55 UTC) #3

> LKGR is 52636, maybe that has something to do with it.

Looks likely. Oh well, I'll head out and check this in over the weekend or on
Monday. Thanks!

- Pam

Expand Messages | Collapse Messages