Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/pref_service.cc

Issue 2835042: Don't instantiate an ExtensionPrefStore.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/pref_service.cc
===================================================================
--- chrome/browser/pref_service.cc (revision 52679)
+++ chrome/browser/pref_service.cc (working copy)
@@ -94,7 +94,10 @@
// static
PrefService* PrefService::CreatePrefService(const FilePath& pref_filename) {
PrefStore* managed_prefs = NULL;
- ExtensionPrefStore* extension_prefs = new ExtensionPrefStore(NULL);
+ // TODO(pamg): Reinstate extension pref store after Mstone6 branch, when its
+ // memory leaks are fixed and any extension API is using it.
+ // ExtensionPrefStore* extension_prefs = new ExtensionPrefStore(NULL);
+ ExtensionPrefStore* extension_prefs = NULL;
CommandLinePrefStore* command_line_prefs = new CommandLinePrefStore(
CommandLine::ForCurrentProcess());
PrefStore* local_prefs = new JsonPrefStore(
@@ -142,7 +145,8 @@
recommended_prefs);
PrefService* pref_service = new PrefService(value_store);
- extension_prefs->SetPrefService(pref_service);
+ // TODO(pamg): Uncomment when ExtensionPrefStore is reinstated.
+ // extension_prefs->SetPrefService(pref_service);
return pref_service;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698