Issue 2833050: [Mac] Moving some new third party code into its proper dir. Also tweak the ra...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2833050: [Mac] Moving some new third party code into its proper dir. Also tweak the ra... (Closed)

Created:
10 years, 5 months ago by Bons

Modified:
9 years, 5 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Moving some new third party code into its proper dir. Also tweak the radius of the close button hover state circle a bit. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51417

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -258 lines)			Patch
M	chrome/browser/cocoa/DEPS	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	chrome/browser/cocoa/hover_close_button.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/cocoa/third_party/LICENSE	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	chrome/browser/cocoa/third_party/NSBezierPath+MCAdditions.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	chrome/browser/cocoa/third_party/NSBezierPath+MCAdditions.m	View	1 chunk	+0 lines, -188 lines	0 comments	Download
D	chrome/browser/cocoa/third_party/README.chromium	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+3 lines, -2 lines	1 comment	Download
A +	third_party/molokocacao/LICENSE	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	third_party/molokocacao/NSBezierPath+MCAdditions.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	third_party/molokocacao/NSBezierPath+MCAdditions.m	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	third_party/molokocacao/README.chromium	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

10 years, 5 months ago (2010-07-01 18:49:58 UTC) #1

LGTM

http://codereview.chromium.org/2833050/diff/4001/5001
File chrome/browser/cocoa/DEPS (right):

http://codereview.chromium.org/2833050/diff/4001/5001#newcode2
chrome/browser/cocoa/DEPS:2: "+third_party/molokocacao", # For NSBezierPath
additions.
Two spaces after the comma.

http://codereview.chromium.org/2833050/diff/4001/5007
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/2833050/diff/4001/5007#newcode2890
chrome/chrome_browser.gypi:2890: # MolokoCacao additions
These should be before Mozilla --> alphabetize.

Expand Messages | Collapse Messages