Issue 2829039: [PATCH 4/5] update_bootloaders.sh, create_esp.sh: add two helpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2829039: [PATCH 4/5] update_bootloaders.sh, create_esp.sh: add two helpers (Closed)

Created:
10 years, 5 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Visibility:
Public.

Description

[PATCH 4/5] update_bootloaders.sh, create_esp.sh: add two helpers Adds two helpers that are not used yet. They will be used in the next CL to unify the bootloaders in use in build_image. TEST=used in the next CL but otherwise not called. BUG=chromium-os:327

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -0 lines)			Patch
	A	create_esp.sh	View		1 chunk	+34 lines, -0 lines	0 comments	Download
	A	update_bootloaders.sh	View		1 chunk	+201 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 5 months ago (2010-07-02 20:42:05 UTC) #2

LGTM

http://codereview.chromium.org/2829039/diff/1/3
File update_bootloaders.sh (right):

http://codereview.chromium.org/2829039/diff/1/3#newcode50
update_bootloaders.sh:50: update_x86_bootloaders() {
what's w/ defining this fn in 2 places? is it a temporary thing (in this stream
of patches)? (per IM discussion, i see it's a temporary measure so avoid having
to do 2 commit simultaneously. that's fine)

http://codereview.chromium.org/2829039/diff/1/3#newcode96
update_bootloaders.sh:96: # This shouldn't happen.
can you call the other script here?

Expand Messages | Collapse Messages