Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2828021: Take 2: sync changes to support encryption (Closed)

Created:
10 years, 6 months ago by albertb
Modified:
9 years, 3 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, tim (not reviewing), idana
Visibility:
Public.

Description

Take 2: sync changes to support encryption Attempting to resubmit this change. It looks like the reason for the build break on linux was a missing dependency (nss) in the interactive_ui_test target. BUG=32410 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50646

Patch Set 1 #

Patch Set 2 : fix linux_view deps #

Patch Set 3 : fix flaky password test under valgrind #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -66 lines) Patch
M chrome/browser/sync/engine/apply_updates_command.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/apply_updates_command_unittest.cc View 3 chunks +140 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/build_and_process_conflict_sets_command.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc View 5 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/sync/engine/model_safe_worker.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.h View 7 chunks +32 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 1 2 18 chunks +97 lines, -14 lines 0 comments Download
M chrome/browser/sync/engine/syncapi_unittest.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/syncer_util.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer_util.cc View 6 chunks +37 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/update_applicator.h View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/update_applicator.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 5 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 5 chunks +36 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 4 chunks +28 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 2 3 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/sync/protocol/password_specifics.proto View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/syncable/directory_manager.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/sync/syncable/directory_manager.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/util/cryptographer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/util/cryptographer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/test/interactive_ui/interactive_ui_tests.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
albertb
10 years, 6 months ago (2010-06-23 02:11:29 UTC) #1
albertb
Most of the trybots are green. It looks like linux_valgrind is running out of RAM ...
10 years, 6 months ago (2010-06-23 20:03:32 UTC) #2
ncarter (slow)
10 years, 6 months ago (2010-06-23 20:13:30 UTC) #3 
On 2010/06/23 20:03:32, albertb wrote:
> Most of the trybots are green.
> 
> It looks like linux_valgrind is running out of RAM when linking the unit_test
> binary, which is also happening for other users. It is running fine locally
> though.
> 
> In the case of win, it passed earlier this morning, but now chokes on
> invalidation-client.h which is also happening for other users.

LGTM

Powered by Google App Engine
This is Rietveld 408576698