Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chrome/browser/sync/glue/password_change_processor.cc

Issue 2828021: Take 2: sync changes to support encryption (Closed)
Patch Set: fix flaky password test under valgrind Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/password_change_processor.cc
diff --git a/chrome/browser/sync/glue/password_change_processor.cc b/chrome/browser/sync/glue/password_change_processor.cc
index a860ae06e27aee35d89e6fe98f30a775ced079df..93143e6aa91ce3196e0d580c25cbf217e1b7db06 100644
--- a/chrome/browser/sync/glue/password_change_processor.cc
+++ b/chrome/browser/sync/glue/password_change_processor.cc
@@ -153,12 +153,8 @@ void PasswordChangeProcessor::ApplyChangesFromSyncModel(
DCHECK(password_root.GetId() == sync_node.GetParentId());
DCHECK(syncable::PASSWORDS == sync_node.GetModelType());
- sync_pb::PasswordSpecificsData password_data;
- if (!sync_node.GetPasswordSpecifics(&password_data)) {
- error_handler()->OnUnrecoverableError(FROM_HERE,
- "Could not read password specifics");
- return;
- }
+ const sync_pb::PasswordSpecificsData& password_data =
+ sync_node.GetPasswordSpecifics();
webkit_glue::PasswordForm password;
PasswordModelAssociator::CopyPassword(password_data,
&password);
« no previous file with comments | « chrome/browser/sync/engine/update_applicator.cc ('k') | chrome/browser/sync/glue/password_model_associator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698