Fix HistoryTest.testForge on Win...

Fix HistoryTest.testForge on Win

Python's time might be slightly off from Chrome's time on win.
In HistoryTest.testForge this affects the ordering of the history entries.
Make the test function robust to this.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51579

[John Grabowski, 2010-07-02 23:53:02]

LGTM

http://codereview.chromium.org/2825036/diff/1/2
File chrome/test/functional/history.py (right):

http://codereview.chromium.org/2825036/diff/1/2#newcode190
chrome/test/functional/history.py:190: now = time.time() + 5
perhaps refactor into a routine called getNextTime() or whatever that is defined
to "get a time later than any previously returned time".  Makes things more
clear than just "+5".

def getNextTime(self):
  x = time.time()
  while True:
    y = time.time()
    if y == x:
      y += 1
    x = y
    yield y

[Nirnimesh, 2010-07-03 00:15:18]

http://codereview.chromium.org/2825036/diff/1/2
File chrome/test/functional/history.py (right):

http://codereview.chromium.org/2825036/diff/1/2#newcode190
chrome/test/functional/history.py:190: now = time.time() + 5

> def getNextTime(self):
>   x = time.time()
>   while True:
>     y = time.time()
>     if y == x:
>       y += 1
>     x = y
>     yield y
> 

Part of the problem is that Chrome's time is slightly out of sync with python's
time.
So when I add a history item "now" (at python time = 1.2345) it gets added in
chromium with time~=1.2445, and then you do add the next history item giving it
time=1.2400, which is still newer than 1.2445. And the ordering is still
reversed. :(

[John Grabowski, 2010-07-03 00:18:57]

So make +=10; no problem.


On Fri, Jul 2, 2010 at 5:15 PM, <nirnimesh@chromium.org> wrote:

>
> http://codereview.chromium.org/2825036/diff/1/2
> File chrome/test/functional/history.py (right):
>
> http://codereview.chromium.org/2825036/diff/1/2#newcode190
> chrome/test/functional/history.py:190: now = time.time() + 5
>
>  def getNextTime(self):
>>   x = time.time()
>>   while True:
>>     y = time.time()
>>     if y == x:
>>       y += 1
>>     x = y
>>     yield y
>>
>
>
> Part of the problem is that Chrome's time is slightly out of sync with
> python's time.
> So when I add a history item "now" (at python time = 1.2345) it gets
> added in chromium with time~=1.2445, and then you do add the next
> history item giving it time=1.2400, which is still newer than 1.2445.
> And the ordering is still reversed. :(
>
>
> http://codereview.chromium.org/2825036/show
>