Fix HistoryTest.testForge on Win...

chrome/test/functional/history.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import time
 
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
@@ skipping 165 matching lines @@
 
     Note the history system can tweak values (e.g. lower-case a URL or
     append an '/' on it) so be careful with exact comparison.
     """
     assert not self.GetHistoryInfo().History(), 'Expecting clean history.'
     # Minimal interface
     self.AddHistoryItem({'url': 'http://ZOINKS'})
     history = self.GetHistoryInfo().History()
     self.assertEqual(1, len(history))
     self.assertTrue('zoinks' in history[0]['url'])  # yes it gets lower-cased.
+    # Python's time might be slightly off (~10 ms) from Chrome's time (on win).
+    # time.time() on win counts in 1ms steps whereas it's 1us on linux.
+    # So give the new history item some time separation, so that we can rely
+    # on the history ordering.
+    now = time.time() + 5

[John Grabowski, 2010/07/02 23:53:02]

perhaps refactor into a routine called getNextTime() or whatever that is defined
to "get a time later than any previously returned time".  Makes things more
clear than just "+5".

def getNextTime(self):
  x = time.time()
  while True:
    y = time.time()
    if y == x:
      y += 1
    x = y
    yield y

[Nirnimesh, 2010/07/03 00:15:18]

Part of the problem is that Chrome's time is slightly out of sync with python's
time.
So when I add a history item "now" (at python time = 1.2345) it gets added in
chromium with time~=1.2445, and then you do add the next history item giving it
time=1.2400, which is still newer than 1.2445. And the ordering is still
reversed. :(

     # Full interface (specify both title and url)
-    now = time.time()
     self.AddHistoryItem({'title': 'Google',
                          'url': 'http://www.google.com',
                          'time': now})
     # Expect a second item
     history = self.GetHistoryInfo().History()
     self.assertEqual(2, len(history))
     # And make sure our forged item is there.
     self.assertEqual('Google', history[0]['title'])
     self.assertTrue('google.com' in history[0]['url'])
     self.assertTrue(abs(now - history[0]['time']) < 1.0)
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()