chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc - Issue 2825018: Canvas refactoring part 3....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc

Issue 2825018: Canvas refactoring part 3.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc

===================================================================

--- chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc (revision 50664)

+++ chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc (working copy)

@@ -34,7 +34,7 @@

size_t command_id = 1; // Menu id 0 is reserved, start with 1.

for (size_t i = start_index; i < views_->size(); ++i) {

BrowserActionView* view = (*views_)[i];

- scoped_ptr<gfx::CanvasSkia> canvas(view->GetIconWithBadge());

+ scoped_ptr<gfx::Canvas> canvas(view->GetIconWithBadge());

menu_->AppendMenuItemWithIcon(

command_id,

UTF8ToWide(view->button()->extension()->name()),