Issue 2822010: Fixes bug in bookmark bar view if profile changed. If the profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2822010: Fixes bug in bookmark bar view if profile changed. If the profile (Closed)

Created:
10 years, 6 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews

Visibility:
Public.

Description

Fixes bug in bookmark bar view if profile changed. If the profile changed we didn't remove the old buttons, which meant when you clicked on a button it might be past the bounds of the model. I don't think we ever do this, but it's the only thing I could see that could cause the crash. Once I've nailed this down I'll nuke the CHECKs. BUG=44642 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49959

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -23 lines)			Patch
M	chrome/browser/views/bookmark_bar_view.h	View	3 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	4 chunks	+18 lines, -9 lines	0 comments	Download
A	chrome/browser/views/bookmark_bar_view_unittest.cc	View	1 chunk	+48 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/test/browser_with_test_window_test.h	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages